RDKEMW-23354: mics occasionally muted at boot - #268

src/voice/ctrlm_voice_obj.cpp:3732

• voice_update_privacy() reads device_status without taking device_status_semaphore, and the mismatch resolution can never take effect because it branches on voice_is_privacy_enabled() (ctrlm state) and then calls voice_privacy_enable/disable(), which will early-return when ctrlm already matches that value. If the intent is to refresh ctrlm privacy based on the VSDK (like voice_power_state_change() does), make VSDK the source of truth and only then update ctrlm/DB, while keeping semaphore usage consistent.

void ctrlm_voice_t::voice_update_privacy() {
    if(this->local_mic) {
        // Read privacy mode state from the DB in case power cycle lost HW GPIO state
        if(this->device_status[CTRLM_VOICE_DEVICE_MICROPHONE] & CTRLM_VOICE_DEVICE_STATUS_DISABLED) {
            XLOGD_INFO("voice is disabled, skip privacy");

src/voice/ctrlm_voice_obj_generic.cpp:400

• voice_update_privacy() is called even when xrsr_route(routes) fails. Since the purpose is to refresh privacy after a successful route update, keep the privacy refresh in the success path so failures don’t trigger additional VSDK privacy reads/writes during an already-failed route update.

    //Updating routes means updating inputs and outputs, so refresh the privacy setting in case inputs changed
    this->voice_update_privacy();

src/voice/ctrlm_voice_obj_generic.cpp:400

• voice_update_privacy() is called even when xrsr_route(routes) fails. If routes/inputs/outputs were not successfully updated, refreshing privacy based on the VSDK at this point can persist an incorrect state (and the call intent in the comment is no longer true). Consider returning early on route failure and only refreshing privacy after a successful xrsr_route call.

    if(!xrsr_route(routes)) {
        XLOGD_ERROR("failed to set routes");
    }

    //Updating routes means updating inputs and outputs, so refresh the privacy setting in case inputs changed
    this->voice_update_privacy();

src/voice/ctrlm_voice_obj.cpp:3738

• voice_update_privacy() uses vsdk_is_privacy_enabled(), which defaults privacy to ON when xrsr_privacy_mode_get fails. Persisting that default into ctrlm/DB here can incorrectly mute mics (and make the boot issue worse if the privacy query is still transiently failing). It’s safer to only update ctrlm/DB when the VSDK privacy query succeeds, otherwise leave the existing ctrlm/DB privacy state unchanged.

     // Refresh ctrlm/DB privacy state from the VSDK after route/input updates.
     const bool privacy_vsdk  = this->vsdk_is_privacy_enabled();
     const bool privacy_ctrlm = this->voice_is_privacy_enabled();
     if(privacy_vsdk != privacy_ctrlm) {
         privacy_vsdk ? this->voice_privacy_enable(false) : this->voice_privacy_disable(false);
     }